fix(directive): throw if output the same event more than once #5113
Conversation
| if (isPresent(dm.outputs)) { | ||
| dm.outputs.forEach((propName: string) => { | ||
| if (ListWrapper.contains(outputs, propName)) { | ||
| throw new BaseException( |
There was a problem hiding this comment.
Could you include the type name as well in the error message?
There was a problem hiding this comment.
Replaced selector with type name
erictsangx
force-pushed
the
check-dulplicate-outputs
branch
from
152396e
to
cb5cbde
Compare
| throw new BaseException( | ||
| `Output the same event more than once: '${propName}' in '${stringify(this.type)}'`); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Could it be that dm.OUTPUTS contains the same event twice ? Should we check that too ?
There was a problem hiding this comment.
I thought about it. I decided not to check since outputs: ['eventA','eventA'] should looks weird.
erictsangx
force-pushed
the
check-dulplicate-outputs
branch
2 times, most recently
from
07f0b46
to
4813c94
Compare
| dm.outputs.forEach((propName: string) => { | ||
| if (ListWrapper.contains(outputs, propName)) { | ||
| throw new BaseException( | ||
| `Output the same event more than once: '${propName}' in '${stringify(type)}'`); |
There was a problem hiding this comment.
can you change the message to "Output event '${propName}' defined multiple times in '${stringify(type)}'
|
the rest looks good |
IgorMinar
added
pr_state: LGTM
action: cleanup
erictsangx
force-pushed
the
check-dulplicate-outputs
branch
from
4813c94
to
3dece56
Compare
|
@IgorMinar updated |
erictsangx
force-pushed
the
check-dulplicate-outputs
branch
from
3dece56
to
b56581e
Compare
IgorMinar
added
action: merge
|
Merge instructions: if problems are identified during merge & sync lets punt this to beta.1 // @alexeagle |
|
Merging PR #5113 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5113. |
|
Merging PR #5113 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-5113. |
|
Merging PR #5113 on behalf of @rkirov to branch presubmit-rkirov-pr-5113. |
|
merged at 8c37b7e |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Close: #4798